Skip to content
Snippets Groups Projects

Prevent errors from non-functional notify_post_receive endpoint

Merged username-removed-367626 requested to merge fix-notify-post-receive into master
All threads resolved!

What does this MR do?

Update Gitlab-Shell to follow with the gl_repository migration plan, but disable the notify_post_receive endpoint for the moment, because is currently a no-op in Gitaly

Are there points in the code the reviewer needs to double check?

No

Why was this MR needed?

Follow with the migration plan to introduce the gl_repository variable https://gitlab.com/gitlab-org/gitlab-shell/merge_requests/130#note_29135923 and prevent future errors from notify_post_receive until it makes sense to re-enable it.

Does this MR meet the acceptance criteria?

/cc @jacobvosmaer-gitlab

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • assigned to @eReGeBe

  • Stan Hu resolved all discussions

    resolved all discussions

  • Stan Hu approved this merge request

    approved this merge request

  • merged

  • Stan Hu mentioned in commit a9c1925d

    mentioned in commit a9c1925d

  • This doesn't exactly look like a regression fix for %9.2 to me (please correct me if I'm wrong, @eReGeBe).

    I'll pick this to 9-2-stable after we have three sign-offs, as in https://gitlab.com/gitlab-org/gitlab-ce/blob/master/PROCESS.md#after-the-7th:

    - [x] a release manager: @timothyandrew
    - [x] the VP of Engineering: @stanhu
    - [ ] an Engineering Lead: @DouweM

    Edited by username-removed-407765
  • Picked into 9-2-stable, will go into 9.2.2.

  • Stan Hu mentioned in commit f50598f7

    mentioned in commit f50598f7

  • Please register or sign in to reply
    Loading