Resolve "Remove duplicated config code for filtered search dropdowns"
What does this MR do?
-
Refactor duplicated code that is used to determine whether the hint dropdown should show certain dropdown items. Previously, there was code inside app/views/shared/issuable/_search_bar.html.haml and app/assets/javascripts/filtered_search/filtered_search_token_keys.js to configure which dropdown to show in the hint dropdown
-
Refactor code so that the tokenkeys is determined in
filteredSearchManager
and passed down. In EE, we pass a different tokenkeys file that includes the weight. In the current implementation, there were some weird side effects in EE where weight filters weren't being displayed correctly because of this
EE Version
https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/1932
Are there points in the code the reviewer needs to double check?
Shouldn't be
Why was this MR needed?
Reduce technical debt
Screenshots (if relevant)
None
Does this MR meet the acceptance criteria?
-
Changelog entry added, if necessary -
Documentation created/updated -
API support added - Tests
-
Added for this feature/bug -
All builds are passing
-
-
Conform by the merge request performance guides -
Conform by the style guides -
Branch has no merge conflicts with master
(if it does - rebase it please) -
Squashed related commits together
What are the relevant issue numbers?
Closes #32563 (closed)