Skip to content
Snippets Groups Projects

Resolve "Remove duplicated config code for filtered search dropdowns"

All threads resolved!

What does this MR do?

  1. Refactor duplicated code that is used to determine whether the hint dropdown should show certain dropdown items. Previously, there was code inside app/views/shared/issuable/_search_bar.html.haml and app/assets/javascripts/filtered_search/filtered_search_token_keys.js to configure which dropdown to show in the hint dropdown

  2. Refactor code so that the tokenkeys is determined in filteredSearchManager and passed down. In EE, we pass a different tokenkeys file that includes the weight. In the current implementation, there were some weird side effects in EE where weight filters weren't being displayed correctly because of this

EE Version

https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/1932

Are there points in the code the reviewer needs to double check?

Shouldn't be

Why was this MR needed?

Reduce technical debt

Screenshots (if relevant)

None

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

Closes #32563 (closed)

Edited by username-removed-408677

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • username-removed-408677 resolved all discussions

    resolved all discussions

  • username-removed-408677 unmarked as a Work In Progress

    unmarked as a Work In Progress

  • username-removed-408677 changed the description

    changed the description

  • Phil Hughes approved this merge request

    approved this merge request

  • merged

  • Phil Hughes mentioned in commit 6cbc69aa

    mentioned in commit 6cbc69aa

  • Please register or sign in to reply
    Loading