Add refresh button into MR widget failed state.
Added a Refresh button to auto merge failed state in the MR widget which will allow user to manually refresh the widget.
Fixes #32543 (closed)
Merge request reports
Activity
/cc @DouweM @rymai Fix for #32543 (closed)
@fatihacet was this design made by an UX team member?
😅 It does not seam very aligned.
@dimitrieh can you please help here?
assigned to @dimitrieh
mentioned in issue #32437 (closed)
-
@fatihacet according to the mockups for a similar message it should be shown in the same line as the error: https://gitlab-org.gitlab.io/gitlab-design/hosted/25424-Refine-MR-Widgets-spec-previews/#artboard1
assigned to @fatihacet
@filipa ok I will change the place.
added 1 commit
- a9ad1b61 - MRWidget: Change refresh button place in failed state.
@filipa Updated widget according to your suggestion. This is how it looks now.
Assigning to you without waiting the Pipeline. Can you please keep an eye on the Pipeline? I will try to do but I will be off and away from computer today because it's a national holiday here.
One more thing, this is a Pick into Stable, so I would say let's merge this as is, thanks to your suggestion it looks much better now.
assigned to @filipa
-
@fatihacet I think the message must be:
-
either all in red and in one line:
-
or all in red in several lines:
cc @dimitrieh
I understand this is a regression but I'm a little concerned we are adding a UI regression
🤔 Edited by Filipa Lacerda -
assigned to @fatihacet
@filipa All in red and one line is a different state. This state should be all in red. I will change the color.
assigned to @filipa
-
@fatihacet do we have any tests testing that something actually happens when the button is clicked?
🤔 mentioned in commit 638fa19b
mentioned in issue #32608 (closed)
@filipa created an issue for the missing test https://gitlab.com/gitlab-org/gitlab-ce/issues/32608
Thanks for the merge
👍 Edited by username-removed-502136added regression label
mentioned in commit e49090dc
