Initial implementation for real time job view

• Changelog entry added, if necessary
• Tests
  • Added for this feature/bug
  • All builds are passing

I think its best to merge this first, and than do the frontend and not try and squeeze it into 1 merge request.

/cc @filipa @ayufan

@zj Thanks. It looks quite cool and simple a few remarks. I think that @filipa should become happy now :)

mentioned in issue #32950 (moved)

marked the checklist item Changelog entry added, if necessary as completed

changed the description

marked the checklist item Added for this feature/bug as completed

added 205 commits

• c17b4b17...8e2fefc6 - 203 commits from branch master
• 822ef8e6 - Initial implementation for real time job view
• 9d92aefa - Create PipelineDetailsEntity

Compare with previous version

resolved all discussions

@ayufan Could you review again?

assigned to @ayufan

@zj You need to review all occurrences of PipelineEntity and probably change them to details, otherwise, some functionalities will be broken.

For now I only see it in MergeRequestEntity.

@zj

BuildArtifactEntity doesn't expose all information needed by frontend as described here: https://gitlab.com/gitlab-org/gitlab-ce/issues/31397#note_30433801

assigned to @zj

For now I only see it in MergeRequestEntity.

It was my understanding this was ok, as they only need the basic details. But just to be sure I'll revert

resolved all discussions

assigned to @ayufan

added ~19173 Deliverable ~901060 labels

assigned to @zj

I did functional review, did not yet look for tests.

One thing that we should probably fix is to introduce json schemas where we modify/introduce data.

assigned to @ayufan

assigned to @zj

assigned to @ayufan

@zj Could you rebase this MR on top of https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/11407?

resolved all discussions

added 394 commits

• 64f4ec48...f06daa26 - 391 commits from branch master
• 47a0276e - Initial implementation for real time job view
• 68569584 - Create PipelineDetailsEntity
• 8a9a62e3 - Incorporate review

Compare with previous version

changed the description

marked the checklist item All builds are passing as completed

@ayufan Fixed the legit spec failure, hopefully no other pop up. 😄

added 1 commit

• 5fdb5124 - Rename build to job

Compare with previous version

@ayufan Fixed the merge conflict. Should be good now. 😄

added 13 commits

• 5fdb5124...dd0f8b8c - 12 commits from branch master
• 8815c462 - Merge remote-tracking branch 'origin/master' into zj-job-view-goes-real-time

Compare with previous version

added 1 commit

• 6c872396 - Merge remote-tracking branch 'origin/master' into zj-job-view-goes-real-time

Compare with previous version

@zj I am seeing this:

NoMethodError at /root/ci-mock/-/jobs/4153
==========================================

> undefined method `iid' for nil:NilClass

app/serializers/build_details_entity.rb, line 16
------------------------------------------------

 ruby
   11     expose :runner, using: RunnerEntity
   12     expose :pipeline, using: PipelineEntity
   13   
   14     expose :merge_request, if: -> (*) { can?(current_user, :read_merge_request, project) } do
   15       expose :iid do |build|
>  16         build.merge_request.iid
   17       end
   18   
   19       expose :path do |build|
   20         namespace_project_merge_request_path(project.namespace, project, build.merge_request)
   21       end

@zj I think I am missing the path to render the new issue button:

new_namespace_project_issue_path(@project.namespace, @project, issue: build_failed_issue_options)

@zj

It seems that we should test can?(current_user, :read_merge_request, build.merge_request).

assigned to @zj

@filipa We do have the issue path: https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/11651/diffs#2b784d3c2739e4adae6d4ecadde852c0a9fcc911_0_24

Thank you @zj 💪 sorry!

@zj will user be in root level, like it is in pipelines/:id.json ? :)

It seems that we should test can?(current_user, :read_merge_request, build.merge_request)

Grep for it :) Its not the case

resolved all discussions

assigned to @ayufan

assigned to @zj

mentioned in merge request !11685 (closed)

assigned to @ayufan

It should stay as retry_path as this action is available not only for .failed?

The previous version was correct, with one change:

  expose :retry_path, if: -> (*) { build.retryable? } do |build|
    path_to(:retry_namespace_project_job, build)
  end

added 1 commit

• b2465182 - Add user to BuildDetailsEntity

Compare with previous version

@zj is retry_path going to be inside build_failed_options?

In other places is in root level :)

@filipa I think that this is typo. It should be root level. I pushed a fix for that failure.

added 183 commits

• b2465182...11852e16 - 181 commits from branch master
• 0383b482 - Merge remote-tracking branch 'origin/master' into zj-job-view-goes-real-time
• b2f997e4 - Fix test failures

Compare with previous version

added 1 commit

• a29ba51e - Fix test failures

Compare with previous version

added 1 commit

• 1709e5cf - retryable? is now available for CommitStatus

Compare with previous version

approved this merge request

mentioned in commit 9ccb289a

merged

mentioned in issue gitlab#10130