An error occurred while fetching the assigned milestone of the selected merge_request.
Fix error thrown with missing note fragment in DOM
All threads resolved!
All threads resolved!
What does this MR do?
- Fix error thrown when loading the diff tab that doesn't have the note associated with the fragment hash in the URL.
Are there points in the code the reviewer needs to double check?
Reproduction:
- Visit a MR with a note hash that doesn't exist,
/namespace/project/merge_requests/x/diffs#note_1234
- Notice the error throw when the diff tab loads
Why was this MR needed?
- An error is thrown when loading the diff tab that doesn't have the note associated with the fragment hash in the URL.
Screenshots (if relevant)
Does this MR meet the acceptance criteria?
- Tests
-
Added for this feature/bug -
All builds are passing
-
-
Conform by the merge request performance guides -
Conform by the style guides -
Branch has no merge conflicts with master
(if it does - rebase it please) -
Squashed related commits together
What are the relevant issue numbers?
Closes #32888 (closed)
Edited by username-removed-892863
Merge request reports
Activity
- Resolved by username-removed-892863
assigned to @ClemMakesApps
assigned to @MadLittleMods
added 1 commit
- 1a896f71 - Fix error thrown with missing note fragment in DOM
assigned to @ClemMakesApps
- Resolved by username-removed-892863
- Resolved by username-removed-408677
added 1 commit
- 07a3a69c - Fix error thrown with missing note fragment in DOM
mentioned in commit a59165e7
mentioned in issue #33450 (closed)
mentioned in merge request !12011 (merged)
@MadLittleMods: This MR doesn't apply cleanly onto
9-2-stable
. Could you please fix the conflicts in https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/12011?mentioned in commit 0d554df6
Please register or sign in to reply