Skip to content
Snippets Groups Projects

Fix error thrown with missing note fragment in DOM

All threads resolved!

What does this MR do?

  • Fix error thrown when loading the diff tab that doesn't have the note associated with the fragment hash in the URL.

Are there points in the code the reviewer needs to double check?

Reproduction:

  1. Visit a MR with a note hash that doesn't exist, /namespace/project/merge_requests/x/diffs#note_1234
  2. Notice the error throw when the diff tab loads

Why was this MR needed?

  • An error is thrown when loading the diff tab that doesn't have the note associated with the fragment hash in the URL.

Screenshots (if relevant)

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

Closes #32888 (closed)

Edited by username-removed-892863

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • username-removed-892863 resolved all discussions

    resolved all discussions

  • added 1 commit

    • 1a896f71 - Fix error thrown with missing note fragment in DOM

    Compare with previous version

  • username-removed-892863 resolved all discussions

    resolved all discussions

  • username-removed-892863 resolved all discussions

    resolved all discussions

  • added 1 commit

    • 07a3a69c - Fix error thrown with missing note fragment in DOM

    Compare with previous version

  • username-removed-408677 resolved all discussions

    resolved all discussions

  • username-removed-408677 approved this merge request

    approved this merge request

  • mentioned in commit a59165e7

  • mentioned in merge request !12011 (merged)

  • @MadLittleMods: This MR doesn't apply cleanly onto 9-2-stable. Could you please fix the conflicts in https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/12011?

  • mentioned in commit 0d554df6

  • Please register or sign in to reply
    Loading