Skip to content
Snippets Groups Projects

Apply responsive note styles to parallel diffs

All threads resolved!

What does this MR do?

  • Apply responsive note styles to parallel diffs
    • Add notes-media mixin that inserts a side by side CSS rule that applies to notes in a parallel layout.

Inspired while working on https://gitlab.com/gitlab-org/gitlab-ce/issues/32801

Are there points in the code the reviewer needs to double check?

  • Where should the notes-media mixin live?

Why was this MR needed?

  • We only had a few response bare-necessities applied to parallel diff notes compared to normal notes. Things kicked in way too late given they are side by side.

Screenshots (if relevant)

. Screenshot
Before
After

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

Edited by username-removed-892863

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Annabel Gray resolved all discussions

    resolved all discussions

  • added 70 commits

    • e797aba2...3605e430 - 69 commits from branch master
    • ea504a71 - Apply responsive note styles to parallel diffs

    Compare with previous version

  • Annabel Gray
  • Annabel Gray resolved all discussions

    resolved all discussions

  • mentioned in issue #32985 (closed)

  • Annabel Gray resolved all discussions

    resolved all discussions

  • Annabel Gray approved this merge request

    approved this merge request

  • Annabel Gray changed milestone to %9.3

    changed milestone to %9.3

  • merged

  • Annabel Gray mentioned in commit 3ae070c9

    mentioned in commit 3ae070c9

  • Please register or sign in to reply
    Loading