Skip to content

Don't allow spaces in dependency linker value regex

Douwe Maan requested to merge dm-dependency-value-regex into master

Fixes bug in https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/11226 that caused JSON values to be incorrectly recognized as package names if their key was also the key for a real package in dependencies or devDependencies.

Before

Screen_Shot_2017-05-25_at_15.53.52

The two scripts above matched the REPO_REGEX because they both contain a single slash.

After

Screen_Shot_2017-05-25_at_15.55.12

Edited by Douwe Maan

Merge request reports