Skip to content
Snippets Groups Projects

Creates CI Header component to use in pipelines and job details pages

Merged Filipa Lacerda requested to merge ci-build-pipeline-header-vue into master
All threads resolved!

What does this MR do?

Creates a reusable shared component between pipeline's details page and job's detail page.

The original MR is https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/11340, this is just a port in order to merge it into master directly.

Why was this MR needed?

The goal is to make both pipeline's details page and job's detail page realtime. This header is shared between them.

Screenshots (if relevant)

Screen_Shot_2017-05-26_at_08.37.03

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

#31397 (closed)

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Looks pretty simple 👍 Just some small comments 😄

  • Filipa Lacerda resolved all discussions

    resolved all discussions

  • Author Maintainer

    @iamphill done 👍 Also changed the mixing to have methods like it had in the 1st MR, makes it easier to use :)

    Can you please review again? Thanks!

  • Author Maintainer

    Ups, forgot to update the tests 🤦

  • assigned to @filipa

  • Author Maintainer

    @iamphill can you please review again? Thanks!

  • Just the one thing 👍 Sorry I didn't notice it before!

  • Filipa Lacerda resolved all discussions

    resolved all discussions

  • Author Maintainer

    @iamphill no need to be sorry! Nice catch! :)

    Fixed 💪 Can you review again? Thanks!

  • Phil Hughes approved this merge request

    approved this merge request

  • @filipa Thanks! 😄 enabled MWPS 👍

  • merged

  • Phil Hughes mentioned in commit 7911f1c0

    mentioned in commit 7911f1c0

  • mentioned in issue #36072 (closed)

  • Please register or sign in to reply
    Loading