Skip to content

Fix counter cache invalidation

Valery Sizov requested to merge fix_counter_cache_invalidation into master

What does this MR do?

This MR implements a counter cache invalidation for such cases:

  • Issue reopening
  • Issue closing
  • MR reopening
  • MR closing
  • MR merging

Apart of that, we have set expire_in for that cache so it will not last forever. It will help to workaround the issue https://gitlab.com/gitlab-org/gitlab-ce/issues/32415 which is not fixed yet. And it will also help to mitigate the impact of future bugs like this. Moreover, making cache non-infinite is a good practice.

Are there points in the code the reviewer needs to double check?

Why was this MR needed?

Screenshots (if relevant)Screen_Shot_2017-05-26_at_17.06.06

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/32854 Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/32870 Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/32629

Edited by Valery Sizov

Merge request reports