Skip to content

Ui improvements for count badges and permission badges

What does this MR do?

  • permission badges now feature a pill shape (similar to labels)
  • count badges now feature an opacity based bg instead of a solid color.. this way they adjust automatically based on a darker or lighter background.. looks are the same as they were for top nav... but is very slightly visible for non top nav count badges. This improves contrast very lightly.

Are there points in the code the reviewer needs to double check?

Why was this MR needed?

  • the square shape of the permission labels reminds to much of a button, while these are not buttons or even clickable
  • Count badges depend on translucent color to better adjust to better adjust to different background colors and permission badges now feature a pill shaped design similar to labels

Screenshots (if relevant)

image image

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

none, these were changes from an old closed mr of mine which still have value https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/10473

@tauriedavis can you see to approving this? (if you agree :) ) @annabeldunstone can you see to merging this?

Merge request reports

Loading