Skip to content
Snippets Groups Projects

Update session cookie key name to be unique to instance in development

Merged username-removed-892863 requested to merge 31644-make-cookie-sessions-unique into master
All threads resolved!

What does this MR do?

  • Update session cookie key name to be unique to instance in development, _gitlab_session_dd3e97794060e2134ec763a0bb3dc6d3bbd011b33ea084ef272498a06c6b80b3
    • Generates hash from Rails.root, thanks @DouweM

Are there points in the code the reviewer needs to double check?

Why was this MR needed?

When working with CE and EE on localhost, signing in to one, invalidates the other because they both overwrite the _gitlab_session cookie.

@MadLittleMods, https://gitlab.com/gitlab-org/gitlab-ce/issues/31644

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

Closes #31644 (closed)

Edited by username-removed-892863

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Douwe Maan unapproved this merge request

    unapproved this merge request

  • username-removed-892863 resolved all discussions

    resolved all discussions

  • added 1 commit

    • 0087f939 - Update session cookie key name to be unique to instance in development

    Compare with previous version

  • username-removed-892863 changed the description

    changed the description

  • username-removed-892863 marked the checklist item All builds are passing as completed

    marked the checklist item All builds are passing as completed

  • Douwe Maan approved this merge request

    approved this merge request

  • Douwe Maan enabled an automatic merge when the pipeline for 0087f939 succeeds

    enabled an automatic merge when the pipeline for 0087f939 succeeds

  • merged

  • Douwe Maan mentioned in commit 6f14a3ea

    mentioned in commit 6f14a3ea

  • username-removed-892863 resolved all discussions

    resolved all discussions

  • mentioned in issue #34009 (moved)

  • Please register or sign in to reply
    Loading