An error occurred while fetching the assigned milestone of the selected merge_request.
Update session cookie key name to be unique to instance in development
All threads resolved!
All threads resolved!
What does this MR do?
- Update session cookie key name to be unique to instance in development,
_gitlab_session_dd3e97794060e2134ec763a0bb3dc6d3bbd011b33ea084ef272498a06c6b80b3
- Generates hash from
Rails.root
, thanks @DouweM
- Generates hash from
Are there points in the code the reviewer needs to double check?
Why was this MR needed?
When working with CE and EE on
localhost
, signing in to one, invalidates the other because they both overwrite the_gitlab_session
cookie.@MadLittleMods, https://gitlab.com/gitlab-org/gitlab-ce/issues/31644
Does this MR meet the acceptance criteria?
-
Changelog entry added, if necessary - Tests
-
All builds are passing
-
-
Conform by the merge request performance guides -
Conform by the style guides -
Branch has no merge conflicts with master
(if it does - rebase it please) -
Squashed related commits together
What are the relevant issue numbers?
Closes #31644 (closed)
Edited by username-removed-892863
Merge request reports
Activity
added 1 commit
- 177b788c - Update session cookie key name to be unique to instance in development
- Resolved by username-removed-892863
assigned to @MadLittleMods
added 1 commit
- 0087f939 - Update session cookie key name to be unique to instance in development
assigned to @DouweM
enabled an automatic merge when the pipeline for 0087f939 succeeds
mentioned in commit 6f14a3ea
- Resolved by username-removed-892863
mentioned in issue #34009 (moved)
Please register or sign in to reply