Fix NPE with horse racing emoji check

What does this MR do?

• Fix NPE with horse racing emoji check

Are there points in the code the reviewer needs to double check?

Sentry shows it reproducing on these pages but I am unable to reproduce, https://sentry.gitlap.com/gitlab/gitlabcom-clientside/issues/31095/

• https://gitlab.com/gitlab-org/gitlab-ce/issues/7889
• https://gitlab.com/gitlab-org/gitlab-ee/issues/91
• https://gitlab.com/gitlab-org/gitlab-ce/issues/18231
• https://gitlab.com/gitlab-org/gitlab-recipes/issues/57

I could see it happening with an empty (or just with whitespace) <gl-emoji></gl-emoji> which would originate from a BE markdown banzai issue. But I don't get that on those reproduction pages either. Perhaps a browser extension getting rid of content?

Why was this MR needed?

• JS error thrown in some situations, https://sentry.gitlap.com/gitlab/gitlabcom-clientside/issues/31095/

Does this MR meet the acceptance criteria?

• Tests
  • Added for this feature/bug
  • All builds are passing
• Conform by the merge request performance guides
• Conform by the style guides
• Branch has no merge conflicts with master (if it does - rebase it please)
• Squashed related commits together

What are the relevant issue numbers?

Closes #32587 (closed)

changed the description

marked the checklist item Added for this feature/bug as completed

restored source branch 32587-fix-horse-racing-emoji-codepointat-npe

changed the description

added 114 commits

• 9586a9d1...256a8601 - 113 commits from branch master
• c88d9cf3 - Fix NPE with horse racing emoji check

Compare with previous version

changed the description

marked the checklist item All builds are passing as completed

assigned to @mikegreiling

this LGTM 👍

@alfredo1 can you merge this?

assigned to @alfredo1

@alfredo1 Friendly ping for review/merge

@MadLittleMods I can't do merges at the moment. Passing this to @filipa

assigned to @filipa

changed the description

Although this changes won't hurt, if we can't reproduce and don't know why it is happening, can we be sure this is the fix? 🤔

@MadLittleMods I left a comment. :)

assigned to @MadLittleMods

assigned to @filipa

@filipa We can't be sure this is a fix but we made the code more robust to handle the given situation from Sentry.

approved this merge request

resolved all discussions

merged

mentioned in commit 0601ac5d