Replace PhantomJS with headless Chrome in frontend test suite
What does this MR do?
-
adds karma-chrome-launcher
to devDependencies -
removes karma-phantomjs-launcher
from devDependencies -
replaces PhantomJS
withChromeHeadless
browser config inkarma.config.js
-
fixes failing tests -
remove phantomjs-specific hacks from tests -
updates .gitlab-ci.yml
to utilize new docker image containing headless Chrome
Are there points in the code the reviewer needs to double check?
- karma test job should pass
Why was this MR needed?
see #30876 (moved)
Screenshots (if relevant)
Does this MR meet the acceptance criteria?
-
Changelog entry added, if necessary - Tests
-
Added for this feature/bug -
All builds are passing
-
-
Branch has no merge conflicts with master
(if it does - rebase it please) -
Squashed related commits together
What are the relevant issue numbers?
part of #30876 (moved)
related: gitlab-build-images#10 (closed)
Merge request reports
Activity
mentioned in merge request gitlab-build-images!41 (merged)
waiting on gitlab-build-images!41 (merged) before I can update the docker image in
.gitlab-ci.yml
and then this should be good to gomentioned in issue #30876 (moved)
@mikegreiling Awesome !
added 1 commit
- b355e290 - update karma job to use chrome build image created by gitlab-build-images!41 (merged)
mentioned in commit 59c0fbda
added 139 commits
- 76bd6359...de20057c - 132 commits from branch
master
- ac26ce32 - replace PhantomJS with headless Chrome as karma test runner
- 0ff932cd - fix incorrect equals assertion
- 9a79de13 - remove phantomjs from our frontend dev dependencies
- 68d701da - test new docker image with headless chrome
- 5c296cce - update karma job to use chrome build image created by gitlab-build-images!41 (merged)
- 037b0706 - remove phantomjs-specific test hacks
- 59c0fbda - add CHANGELOG.md entry for !12036 (merged)
Toggle commit list- 76bd6359...de20057c - 132 commits from branch
marked the checklist item Changelog entry added, if necessary as completed
changed milestone to %9.4
@timzallmann can you review/merge?
assigned to @timzallmann
@mikegreiling LGTM
mentioned in commit 1b54982f
mentioned in issue #33633 (closed)
mentioned in commit a526e619
mentioned in merge request !12137 (merged)
mentioned in commit 9d17923e
mentioned in merge request !12144 (merged)
mentioned in commit 931ab01a
mentioned in commit 86a2d9bf
mentioned in issue winni/angular-sudoku#13 (closed)
mentioned in issue #33735 (closed)