An error occurred while fetching reviewers.
Resolve "MR comment + system note highlight don't have the same width"
Merged
requested to merge 33917-mr-comment-system-note-highlight-don-t-have-the-same-width into master
What does this MR do?
Fixes inconsistencies in issuable discussion comments and notes (see before/after pics)
Are there points in the code the reviewer needs to double check?
Play around with comments, notes, diff discussions, and threaded comments in different screen widths to make sure nothing has broken. I've tested this in Safari 10, Chrome 59, and Firefox.
Why was this MR needed?
Issue/MR notes and comments had different widths, leading to inconsistent bottom-borders separators and odd looking highlighting behavior.
Screenshots (if relevant)
before | after |
---|---|
highlighted note | highlighted note |
highlighted comment | highlighted comment |
small viewport | small viewport |
mobile viewport | mobile viewport |
Does this MR meet the acceptance criteria?
-
Changelog entry added, if necessary -
Documentation created/updated -
API support added - Tests
-
Added for this feature/bug -
All builds are passing
-
-
Conform by the merge request performance guides -
Conform by the style guides -
Branch has no merge conflicts with master
(if it does - rebase it please) -
Squashed related commits together
What are the relevant issue numbers?
Closes #33917 (closed)
Edited by username-removed-636429
Merge request reports
Activity
Filter activity
Please register or sign in to reply