Resolve ""Add Members" drop-down doesn't separate Name/Username"

What does this MR do?

It fixes + aligns the styling of multi select user items. Spacing + Bold + @ sign changed. I thought about aligning it with the styling of single select but the avatar has s24 on purpose so it looks like a deliberate decision to have the one line format (which makes sense cause you see more results at once).

Screenshots (if relevant)

Before :

After :

Does this MR meet the acceptance criteria?

• Documentation created/updated
• Conform by the merge request performance guides
• Conform by the style guides
• Branch has no merge conflicts with master (if it does - rebase it please)
• Squashed related commits together

What are the relevant issue numbers?

Closes #33981 (closed)

unmarked as a Work In Progress

changed the description

assigned to @iamphill

Should we just return it the previous styling?

It used to look like:

but with this change it looks like:

/cc @tauriedavis what do you think?

assigned to @timzallmann

I think we should match the design that we are using across the site for dropdowns that contain members:

@tauriedavis Ok Thanks then i will go for the 32px version of the avatar. The only thing in your screenshot it doesn't look bold but i see dropdowns like that (issue sidebar) :

Yeah, we probably need a separate issue just address the consistency between these user drop downs. https://gitlab.com/gitlab-org/gitlab-ce/issues/34146

There is also the @ mention dropdown which is different:

I will make a separate issue but for now let's go with the bolded name and unbolded username so we can get this in.

Thanks @tauriedavis , i also have the search box consistent https://gitlab.com/gitlab-org/gitlab-ce/issues/26303 and i think there might also one about coloring and maybe users, will search later.

@tauriedavis New Version (color is off but i don't want to create another specific override, that should then get solved through align all dropdown coloring issue) :

Sounds good

Thank you !

changed the description

assigned to @annabeldunstone

approved this merge request

LGTM!

changed milestone to %9.3

merged

mentioned in commit 0c351e21

Picked into 9-3-stable, will go in 9.3.1

mentioned in commit 72242f64

mentioned in issue #34310 (closed)