Fix dropdown position for the new button on mobile for the top navbar
What does this MR do?
Fixes the dropdown position for mobile screens on the top navbar for the new
button
Screenshots (if relevant)
Before
After
Does this MR meet the acceptance criteria?
-
Changelog entry added, if necessary - Tests
-
All builds are passing
-
-
Conform by the merge request performance guides -
Conform by the style guides -
Branch has no merge conflicts with master
(if it does - rebase it please) -
Squashed related commits together
What are the relevant issue numbers?
closes #34139 (closed)
Merge request reports
Activity
@annabeldunstone Can you take a look when you get a chance? Thanks!
Also I had a couple of questions, what do you think of the positioning, should I move it a little bit to the left?
Also this is a small change, should I still add a changelog?
assigned to @annabeldunstone
cc @tauriedavis do you have any input?
assigned to @jivanvl
changed milestone to %9.3
Yeah, lets align it with the user dropdown. Good catch, @annabeldunstone.
@annabeldunstone I think I got it
assigned to @annabeldunstone
- Resolved by Annabel Gray
mentioned in issue #33531 (closed)
LGTM! Thanks @jivanvl
mentioned in commit a4ca7e8b
mentioned in commit acfad512
mentioned in issue #34468 (closed)
This may introduced a regression on admin (#34468 (closed)). cc @jivanvl @annabeldunstone
395 395 .dropdown-menu-align-right { 396 396 left: auto; 397 397 right: 0; 398 margin-top: -5px; 399 400 @media (max-width: $screen-xs-max) { 401 left: 0; @jivanvl Why did you specify
left: 0
while this class isalign right
. This caused a regression #34468 (closed) and started to block !12325Oh interesting, let me see how I can improve this, let me check out the issue and MR you mentioned to unblock you
Edited by Jose Ivan Vargas LopezThanks, but I made a fix in !12528 (merged).
mentioned in merge request !12528 (merged)
mentioned in issue #34921 (closed)
- Resolved by Winnie Hellmann