Store merge request ref_fetched status in the database
What does this MR do?
It introduces ref_fetched database field for merge request, so we can cache the value and avoid hitting git when displaying a merge request.
Are there points in the code the reviewer needs to double check?
Why was this MR needed?
Does this MR meet the acceptance criteria?
-
Changelog entry added, if necessary [ ] Documentation created/updated[ ] API support added- Tests
-
Added for this feature/bug -
All builds are passing
-
-
Conform by the merge request performance guides -
Conform by the style guides -
Branch has no merge conflicts with master(if it does - rebase it please) -
Squashed related commits together
What are the relevant issue numbers?
Closes #34052 (closed)
Merge request reports
Activity
assigned to @adamniedzielski
changed milestone to %9.4
added 117 commits
- 859f13e1...d4384dc1 - 116 commits from branch
master - d3283000 - Store merge request ref_fetched status in the database
- 859f13e1...d4384dc1 - 116 commits from branch
marked the checklist item Changelog entry added, if necessary as completed
@timothyandrew can you please review?
assigned to @timothyandrew
-
@adamniedzielski: I had one minor comment, and the build is red. Apart from that, looks good to me!
assigned to @adamniedzielski
-
@timothyandrew thanks for the suggestion, it's great!
The build failure does not seem to be related, I cannot reproduce it locally anymore. I created https://gitlab.com/gitlab-org/gitlab-ce/issues/34323.
assigned to @smcgivern
added 1 commit
- 0eb3d18c - Store merge request ref_fetched status in the database
Thanks @adamniedzielski @timothyandrew!
enabled an automatic merge when the pipeline for 0eb3d18c succeeds
mentioned in commit eacce60b
mentioned in issue #36425 (closed)
mentioned in issue #38319 (closed)
