Ensure NotificationRecipientService doesn't modify participants (!12517) · Merge requests · GitLab.org / GitLab FOSS · GitLab

Do not update/delete: Banner broadcast message test data

Do not update/delete: Notification broadcast message test data

username-removed-443319 requested to merge stop-notification-recipient-service-modifying-participants into master Jun 28, 2017

What does this MR do?

In NotificationRecipientService, we currently modify the memoised participants on the target when adding watchers etc. I don't think this caused https://gitlab.com/gitlab-org/gitlab-ce/issues/19931#note_32488132, but it would be good to rule it out.

Are there points in the code the reviewer needs to double check?

Don't think so.

Why was this MR needed?

Modifying a memoised array when you don't intend to is a bad idea!