Inline script cleanup globals and easy
What does this MR do?
It moves inline scripts to js files, dispatcher, etc. in the effort to remove inline scripts once and for all gitlab-org/gitlab-ce#34903
Solutions used :
- moves the initialisation to dispatcher
- moves the variables that are transported from Ruby to data attributes
- moves the JS to an page specific file
- sets the block to ignore
The focus was less on refactoring but more on getting it sorted out
Why was this MR needed?
To enable globally deferred script loading we need to get rid of inline javascript that references libraries
Does this MR meet the acceptance criteria?
- Tests
-
Added for this feature/bug -
All builds are passing
-
-
Conform by the merge request performance guides -
Conform by the style guides -
Branch has no merge conflicts with master
(if it does - rebase it please) -
Squashed related commits together
What are the relevant issue numbers?
gitlab-org/gitlab-ce#34903
Edited by Tim Zallmann