Skip to content

Inline script cleanup globals and easy

Tim Zallmann requested to merge inline-script-cleanup-globals-and-easy into master

What does this MR do?

It moves inline scripts to js files, dispatcher, etc. in the effort to remove inline scripts once and for all gitlab-org/gitlab-ce#34903

Solutions used :

  • moves the initialisation to dispatcher
  • moves the variables that are transported from Ruby to data attributes
  • moves the JS to an page specific file
  • sets the block to ignore

The focus was less on refactoring but more on getting it sorted out

Why was this MR needed?

To enable globally deferred script loading we need to get rid of inline javascript that references libraries

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

gitlab-org/gitlab-ce#34903

Edited by Tim Zallmann

Merge request reports

Loading