Skip to content

Short-circuit build coverage extraction for empty regexes

Nick Thomas requested to merge (removed):short-circuit-coverage-with-empty-regex into master

What does this MR do?

Prevents us from scanning the full build trace when the regex will never find anything

Are there points in the code the reviewer needs to double check?

Why was this MR needed?

Minor performance optimization. Some databases have '' as the coverage regex; combined with large build traces, this uses up resources in an avoidable fashion.

For a 100K build trace, scanning with an empty regex currently takes ~1 second locally. A nil regex always takes around 0.01 seconds.

Screenshots (if relevant)

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

Merge request reports