Fix duplicated event for tag removal

username-removed-710385 requested to merge aptituz/gitlab-ce:bugfix_35406 into master

What does this MR do?

The merge request removes some redundant calls, which led to duplicate events for removed tags.

Are there points in the code the reviewer needs to double check?


I'm not entirely sure my assessment how the event is triggered is correct. This should be verified to ensure that the change doesn't break unrelated functionality.

Why was this MR needed?

Issue #35406 (moved): Two events are created for a delete tag event and also two notifications.

Diagnosis: When a tag is removed, the PostReceive worker is being triggered, which in turn triggers GitTagPushService to process the tag changes. This in turn uses EventCreateService to track a push and fires project hooks and services. Thus the explicit calls in Tags::DestroyService are redundant, leading to duplicate events being tracked.

Screenshots (if relevant)

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

#35406 (moved) (and the closed issue: #35506 (closed))

Edited by username-removed-710385

Merge request reports