Make header dropdown styles consistent
Merge request reports
Activity
@cperessini Can you please have a look?
/cc @pedroms
Edited by Winnie Hellmann@winh checked out the branch, looking good!
mentioned in merge request !12938 (merged)
mentioned in issue #28921 (moved)
@cperessini After a second thought, it made more sense to me to cover all dropdowns from the header at once because they don't require switching pages and have the same stylesheet. So I changed the scope of this merge request. Could you have another look please?
- Resolved by Annabel Gray
assigned to @cperessini
mentioned in merge request !13116 (merged)
mentioned in merge request !13182 (merged)
@winh checked out the branch, looks great
@annabeldunstone Can you please review?
assigned to @annabeldunstone
assigned to @winh
Hmm it seems like you'd need to update all the MRs to fix the horizontal line. It might be easier/quicker to get these merged, and then create a separate issue to update the line separators. What do you think @winh?
Can we make all the horizontal lines full-width?
I approve this message
By the way, great job on this @winh!mentioned in issue #35784 (closed)
it looks a little off with the horizontal gray lines no longer matching up with the hover styles
@annabeldunstone Thank you, good point!
create a separate issue to update the line separators. What do you think @winh?
Yes, I think that is a good idea.
I have created #35784 (closed). I will resolve that along with the style deduplication after I went through all dropdowns.Does this otherwise look good to you?
assigned to @annabeldunstone
LGTM! Thanks @winh
mentioned in commit b60014c7
mentioned in merge request !13274 (merged)