Skip to content
Snippets Groups Projects

Make header dropdown styles consistent

Merged Winnie Hellmann requested to merge winh-user-dropdown-style into master
All threads resolved!

What does this MR do?

Changes headers dropdowns to new style.

Screenshots

Before After
Screen_Shot_2017-07-26_at_13.43.11 Screen_Shot_2017-07-26_at_13.42.55
Screen_Shot_2017-07-26_at_21.13.29 Screen_Shot_2017-07-26_at_21.27.17
Screen_Shot_2017-07-26_at_21.14.20 Screen_Shot_2017-07-26_at_21.25.44
Screen_Shot_2017-07-26_at_21.13.37 Screen_Shot_2017-07-26_at_21.27.34
Screen_Shot_2017-07-26_at_21.46.56 Screen_Shot_2017-07-26_at_21.30.43
Screen_Shot_2017-07-26_at_21.14.58 Screen_Shot_2017-07-26_at_21.49.47
Screen_Shot_2017-07-26_at_21.51.47 Screen_Shot_2017-07-26_at_21.38.51
Screen_Shot_2017-07-26_at_21.48.20 Screen_Shot_2017-07-26_at_21.50.31

What are the relevant issue numbers?

#28921 (moved), #35424 (closed)

Edited by Winnie Hellmann

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Winnie Hellmann mentioned in merge request !13116 (merged)

    mentioned in merge request !13116 (merged)

  • Winnie Hellmann mentioned in merge request !13182 (merged)

    mentioned in merge request !13182 (merged)

  • @winh checked out the branch, looks great :thumbsup:

  • Author Developer

    @annabeldunstone Can you please review? :smiley:

  • @winh it looks a little off with the horizontal gray lines no longer matching up with the hover styles. Can we make all the horizontal lines full-width? We already have it like that on some of the dropdowns.

    Screen_Shot_2017-07-31_at_8.53.06_AM

    cc @pedroms

  • assigned to @winh

  • Hmm it seems like you'd need to update all the MRs to fix the horizontal line. It might be easier/quicker to get these merged, and then create a separate issue to update the line separators. What do you think @winh?

  • Can we make all the horizontal lines full-width?

    I approve this message :smile: By the way, great job on this @winh!

  • mentioned in issue #35784 (closed)

  • Author Developer

    it looks a little off with the horizontal gray lines no longer matching up with the hover styles

    @annabeldunstone Thank you, good point! :thumbsup:

    create a separate issue to update the line separators. What do you think @winh?

    Yes, I think that is a good idea. :smiley: I have created #35784 (closed). I will resolve that along with the style deduplication after I went through all dropdowns.

    Does this otherwise look good to you?

  • Annabel Gray resolved all discussions

    resolved all discussions

  • LGTM! Thanks @winh :sparkles:

  • Annabel Gray approved this merge request

    approved this merge request

  • merged

  • Annabel Gray mentioned in commit b60014c7

    mentioned in commit b60014c7

  • Winnie Hellmann mentioned in merge request !13274 (merged)

    mentioned in merge request !13274 (merged)

  • Please register or sign in to reply
    Loading