Skip to content

Ensure Gitlab.config.gitlab.host/port and Gitlab::Application.routes.default_url_options are set correctly in Capybara + :js specs

username-removed-128633 requested to merge 35599-fix-uncontrolled-default_url_options-overriding into master

What does this MR do?

This ensures Gitlab.config.gitlab.host & Gitlab.config.gitlab.port and Gitlab::Application.routes.default_url_options are set correctly in Capybara + :js specs.

Are there points in the code the reviewer needs to double check?

If all the specs pass, I think we're good?

Why was this MR needed?

Because some specs use Gitlab.config.gitlab.host in their assertions, while other specs need to have a Gitlab::Application.routes.default_url_options that reflects the current Capybara server config. This handles both cases elegantly.

What are the relevant issue numbers?

Closes #35599 (closed)

Merge request reports