Skip to content
Snippets Groups Projects

Enforce boolean defaults on Application Settings

Merged username-removed-1144264 requested to merge mk-enforce-boolean-defaults into master
All threads resolved!

What does this MR do?

Enforces defaults and disallows nulls on application_settings boolean columns.

Why was this MR needed?

New application settings have two "defaults":

  • New install: When a record does not exist in application_settings, we use ApplicationSetting.defaults

  • On upgrade: When a record exists, the value defaults to the column default

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

Closes #2750 (closed)

Edited by username-removed-1144264

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • assigned to @mkozono

  • changed milestone to %10.0

  • Douwe Maan resolved all discussions

    resolved all discussions

  • Douwe Maan approved this merge request

    approved this merge request

  • Douwe Maan enabled an automatic merge when the pipeline for 50d147fa succeeds

    enabled an automatic merge when the pipeline for 50d147fa succeeds

  • @mkozono Build is failing; you may want to rebase.

  • added 1350 commits

    Compare with previous version

  • username-removed-1144264 marked as a Work In Progress from 64a3c9936fe48f6047b3b01e3f9cc6192f142de8

    marked as a Work In Progress from 64a3c9936fe48f6047b3b01e3f9cc6192f142de8

  • username-removed-1144264 unmarked as a Work In Progress

    unmarked as a Work In Progress

  • Douwe Maan approved this merge request

    approved this merge request

  • Douwe Maan enabled an automatic merge when the pipeline for c715936e succeeds

    enabled an automatic merge when the pipeline for c715936e succeeds

  • merged

  • Douwe Maan mentioned in commit 62216af8

    mentioned in commit 62216af8

  • Please register or sign in to reply
    Loading