Make time span dropdown style on cycle analytics page consistent

What does this MR do?

Change the time span dropdown on the Cycle Analytics page to new style.

Screenshots

Before	After

What are the relevant issue numbers?

#28921 (moved), #35424 (closed)

@cperessini Can you please have a look?

assigned to @cperessini

mentioned in issue #28921 (moved)

Style inside the dropdown looks good

The menu seems to overlap with the dropdown button, instead of hanging from a few pixels below it. When I've measured the distance in screenshots it's been 3px, but not sure if that has changed.

assigned to @winh

The menu seems to overlap with the dropdown button

This was broken before but I have fixed it nonetheless:

@annabeldunstone Can you review please?

changed the description

assigned to @annabeldunstone

The menu seems to overlap with the dropdown button

This was broken before but I have fixed it nonetheless:

@annabeldunstone Can you review please?

Awesome @winh, thanks a lot for taking care of it!

LGTM! I'm wondering if, since we're using the same chunk of CSS for all these dropdowns (until it's refactored to be global), we should put the whole thing in a mixin? That way we won't have to repeat it so much. What do you think @winh?

I'll merge this in the time being regardless.

approved this merge request

merged

mentioned in commit 3f230455

we should put the whole thing in a mixin?

That's a good idea! I will do that in the next merge request I open.

mentioned in merge request !13193 (merged)

mentioned in merge request !13274 (merged)