Skip to content

Don't include EmailHelpers manually, pick with rspec

username-removed-423915 requested to merge use-rspec-support-helper into master

What does this MR do?

Don't include EmailHelpers manually, pick with rspec

Are there points in the code the reviewer needs to double check?

:mailer, type: :mailer somehow looks a bit silly. Could we do better?

Why was this MR needed?

Picking with rspec is much more flexible, as we could do it for a single test case and having special hooks there. We no longer to need to reset_delivered_emails! in various before blocks.

What are the relevant issue numbers?

Inspired by https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/13254

Merge request reports