Removes default scope from sortable
How I found where order was needed
-
grep "include Sortable
to see what models were using it. - Found previous commits through
git blame
whereSortable
was included (https://gitlab.com/gitlab-org/gitlab-ce/commit/37bf35f0bcba28e271789542fb8c81a6c77236b6, https://gitlab.com/gitlab-org/gitlab-ce/commit/c0faf91ff23815404a95cf4510b43dcf5e331c4f, https://gitlab.com/gitlab-org/gitlab-ce/commit/e0aa5c371ea1c633a0648f13cd7bea35f3aea75c, https://gitlab.com/gitlab-org/gitlab-ce/commit/62ed1c537e9b8aa85d354b377f18083fb71b8e05) - Removed the
default_scope
and found which specs were failing.
There is a high possibility that this MR will not fix all the places where order is needed
Does this MR meet the acceptance criteria?
-
Changelog entry added, if necessary -
Documentation created/updated -
API support added -
Tests added for this feature/bug - Review
-
Has been reviewed by UX -
Has been reviewed by Frontend -
Has been reviewed by Backend -
Has been reviewed by Database
-
-
Conform by the merge request performance guides -
Conform by the style guides -
Squashed related commits together
What are the relevant issue numbers?
Closes #23079 (closed)
Edited by username-removed-117638
Merge request reports
Activity
Please register or sign in to reply