Make issuable dashboard dropdowns consistent

What does this MR do?

Change filter dropdowns on issue and merge request dashboard pages to new style.

Screenshots

Before	After

What are the relevant issue numbers?

#28921 (moved), #35424 (closed)

mentioned in issue #28921 (moved)

assigned to @cperessini

added 525 commits

• 2e502ec7...ef8eb3f6 - 524 commits from branch master
• abcc79be - Make issuable dashboard dropdowns consistent

Compare with previous version

@winh the user dropdowns show the checkmark aligned to the top. That makes sense for rows with only text, but I think since we have profile pictures here, it makes sense to center-align these.

MR	GitLab.com

Any Label and No Label don't retain their checkmarks. Should we fix that here or in a different MR?

since we have profile pictures here, it makes sense to center-align these.

@cperessini I can change that here. What would be the criteria though? Whether the dropdown item contains an avatar? Checking for an image is probably too broad since that could affect icons, too.

@winh I think center-aligned looks better because a lot of uneven blank space is created by the checkmark being in the corner and the avatar being full-height. I can't think of any other type of row where that situation happens, so basing it on the presence of an avatar sounds good

@cperessini It is centered now:

Can you have another look?

added 1 commit

• 573f73f2 - Make issuable dashboard dropdowns consistent

Compare with previous version

@winh I think that's better, thanks! Adding approval.

assigned to @winh

approved this merge request

assigned to @iamphill

resolved all discussions

merged

mentioned in commit 3fd0cd7d

mentioned in merge request !13424 (merged)

mentioned in merge request !13584 (merged)