Move "Move issue" to sidebar

What does this MR do?

• Add "Move issue" UI to right-sidebar
• Remove "Move issue" UI from /group/project/issues/x/edit
• Remove "Move issue" UI from inline issue edit

Are there points in the code the reviewer needs to double check?

EE MR, https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/2715

• Are we okay with using gl_dropdown?
  • Has all the right styles
  • Other sidebar dropdowns use it
• Usage of .js-sidebar-dropdown-toggle instead of .edit-link
  • See https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/13616#note_37946342

Does this MR meet the acceptance criteria?

• Changelog entry added, if necessary
• Documentation created/updated
• API support added
• Tests added for this feature/bug
• Review
  • Has been reviewed by UX
  • Has been reviewed by Frontend
  • Has been reviewed by Backend
• Conform by the merge request performance guides
• Conform by the style guides
• Squashed related commits together

What are the relevant issue numbers?

Closes #34261 (closed)

changed the description

Awesome thanks @MadLittleMods ! @hazelyang : Can you at least take a look at the gifs @MadLittleMods attached.

@MadLittleMods @victorwu Looks great! Thanks!

marked the checklist item Has been reviewed by UX as completed

marked the checklist item Tests added for this feature/bug as completed

marked the checklist item API support added as completed

marked the checklist item Documentation created/updated as completed

marked the checklist item Changelog entry added, if necessary as completed

marked the checklist item Conform by the style guides as completed

marked the checklist item Conform by the merge request performance guides as completed

marked the checklist item Squashed related commits together as completed

changed the description

unmarked as a Work In Progress

changed title from WIP: Move "Move to different project" to sidebar to Move "Move issue" to sidebar

changed the description

assigned to @ClemMakesApps

@grzesiek Please review the new #move_issue endpoint and rspec tests

@MadLittleMods Backend looks nice! I left just a few comments.

1. No project option

@MadLittleMods have we considered removing the No project option in the dropdown? I know it exists currently but the move (no pun intended ) to the sidebar will make this more obvious

Currently on gitlab.com	This MR

2. No matching results

Based on https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/13562#note_37742221, I think we want to make sure the no matching results isn't highlighted. I think you're already leveraging the shared code that @winh used, so I think updating your branch with master should fix this issue

3. Inconsistent tooltips from sidebar

Not 100% sure whether this is something that needs to be fixed in this MR. Otherwise, we need to create a separate issue to address the inconsistency

---

As for the EE MR: https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/2715, I'm going to assign back to you and review it after this CE one is good to go

assigned to @MadLittleMods

@ClemMakesApps @MadLittleMods :

• Agree. The no project option is not needed obviously. Let's remove it if it's a small tweak.
• Small nitpicky detail. Can we make it No matching results without the trailing period.
• What's wrong with the tooltip for the collapsed sidebar case?

What's wrong with the tooltip for the collapsed sidebar case?

The copy reference tooltip overlaps with the sidebar border but I think that's a different issue altogether as the other tooltips don't seem to overlap

Thanks @ClemMakesApps . I totally missed that and was frantically reading the text.

No problem, I created https://gitlab.com/gitlab-org/gitlab-ce/issues/36813 to track that separately

mentioned in issue #37023 (closed)

cc @ClemMakesApps

1. No project option
   • Removed the No project option. I don't see another place that uses autocomplete_projects_path but can you think of another place that might use this endpoint (I checked other project dropdowns but they seem to use the API)?
2. No matching results
   • Looks like it was fixed with select2 but not gl_dropdown. I have moved this issue out to https://gitlab.com/gitlab-org/gitlab-ce/issues/37023
   • I assume we are okay with removing the period for all gl_dropdown's across the app, cc @victorwu
3. Inconsistent tooltips from sidebar
   • Moved out to https://gitlab.com/gitlab-org/gitlab-ce/issues/36813

added 459 commits

• 92328b2a...4428944d - 454 commits from branch master
• f08c4b38 - Move "Move to different project" to sidebar
• 83143a01 - Integrate "Move issue" into sidebar mediator/service/store
• c32b39d4 - Add rspec tests for sidebar move issue
• f147438f - Add "Move issue" docs
• b8aa30f8 - Update move issue with review suggestions

Compare with previous version

added 9 commits

• 5e7494e7...24244d03 - 8 commits from branch master
• fe98a1e8 - Move "Move to different project" to sidebar

Compare with previous version

assigned to @ClemMakesApps

@grzesiek Needs another review glance (Updates in place). One thing that changed was No project was removed from app/controllers/autocomplete_controller.rb.

Since this MR deals with jQuery + Vue and since @iamphill will be back on monday, I'm going to assign this MR for him to finish up the review to make sure everything is

assigned to @iamphill

Do we need to do remote filtering? The current move dropdown does.

Still some open discussions as well.

assigned to @MadLittleMods

@iamphill Good shout, I updated it to use remote filtering as it would only return the last 50 projects previously.

One difference I found is infinite scrolling and pagination. select2 has this feature but gl_drodpown doesn't seem to have something for this yet. People will see up to 50 projects by default and will see up to 50 projects filtered results on their search. I suspect this to affect very little scenarios as manually finding something in 50 item list is a bit difficult and filtering will narrow you down quick just as before. Thoughts on just leaving it for this iteration? Otherwise we could add the same debounced scroll hook to gl_dropdown.

I'll leave the setTimeout discussion open in case you have any thoughts.

mentioned in merge request !13907 (merged)

added 139 commits

• 5ab5ce47...6f0f65be - 138 commits from branch master
• 0d8ce735 - Move "Move to different project" to sidebar

Compare with previous version

assigned to @iamphill

added 72 commits

• 11514336...cbaa015c - 71 commits from branch master
• 65e09cbc - Move "Move to different project" to sidebar

Compare with previous version

@MadLittleMods I'm cool with it not having infinite scrolling & having remote filtering instead

mentioned in issue #37253

Frontend LGTM

assigned to @grzesiek

marked the checklist item Has been reviewed by Frontend as completed

mentioned in merge request !13436 (merged)

added 332 commits

• 65e09cbc...dceb2112 - 331 commits from branch master
• 6710a8f8 - Move "Move to different project" to sidebar

Compare with previous version

added 304 commits

• 6710a8f8...a3af6830 - 303 commits from branch master
• 642ca987 - Move "Move to different project" to sidebar

Compare with previous version

added 1 commit

• 90c60138 - Move "Move to different project" to sidebar

Compare with previous version

rspec-pg 4 25 failure (Import/Export - project import integration test when selecting the namespace path is not prefilled user imports an exported project successfully) is from master, https://gitlab.com/gitlab-org/gitlab-ce/-/jobs/31176876

resolved all discussions

marked the checklist item Has been reviewed by Backend as completed

approved this merge request

mentioned in commit 9e820ae3

merged

Thanks @MadLittleMods and others involved!

Looks good to me! Confirmed that pipeline failure is present on master, so let's merge this!