Make admin user actions dropdown consistent
What does this MR do?
Change user actions dropdown in admin area to new style.
Screenshots
| Page | Before | After |
|---|---|---|
| User admin area |  |
 |
| User admin area |  |
 |
| Branches |  |
 |
| Tags |  |
 |
What are the relevant issue numbers?
Merge request reports
Activity
@cperessini There are two things I don't understand here:
- why is the button red at all even though it is not immediately destructive (there is a confirmation)?
- why is
Remove usernot red?
Could you please clarify how this should be?
assigned to @cperessini
mentioned in issue #28921 (moved)
- why is the button red at all even though it is not immediately destructive (there is a confirmation)?
The use of red here is justified, because it is a destructive action, even if you have a confirmation dialog. What's not right is using a button, it should be a normal row with red text.
- why is
Remove usernot red?
¯_(ツ)_/¯ It should be.
Both rows should be red text. That will diminish their individual impact, but we're not fixing that particular UX aspect with this MR.
assigned to @winh
-
What's not right is using a button, it should be a normal row with red text.
why is
Remove usernot red?¯\(ツ)/¯ It should be.
@cperessini I have changed both lines now to red text instead of red background: https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/13630#screenshots what do you think?
assigned to @cperessini
-
@winh looks good to me. Adding approval.
-
@cperessini Thank you!
@ClemMakesApps can you please review?
assigned to @ClemMakesApps
LGTM, thanks @winh!
mentioned in commit f3203cbb
mentioned in merge request !13557 (closed)
mentioned in merge request !14030 (merged)
mentioned in merge request !13417 (closed)
-
I have updated the description after it turned out that this accidentally handled https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/13417#note_39331899 as well.
