Skip to content

Only require sidekiq-limit_fetch when enabled in settings

username-removed-443319 requested to merge only-limit-fetch-when-requested into master

What does this MR do?

To test this out, run gdk redis-cli monitor | grep limit_fetch:

  1. Before this change, there is a lot of output (all misses), even when throttling is disabled.
  2. After this change, there is no output when throttling is disabled.
  3. Enabling throttling and restarting Sidekiq still does the throttling.

Are there points in the code the reviewer needs to double check?

Don't think so - we already needed people to restart for this to take effect.

Why was this MR needed?

Just having this gem included created a lot of cache misses.

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/36253.

Edited by Robert Speicher

Merge request reports