Skip to content
Snippets Groups Projects

Combine multiple expectations into one for shared system note example

Combine multiple expectations into one for shared system note example
rs-aggregate-system-note-specs into master
1 unresolved thread
Merged Robert Speicher requested to merge rs-aggregate-system-note-specs into master
1 unresolved thread

This takes about 3 minutes on CI. Times below are local:

Baseline

Finished in 1 minute 34.66 seconds (files took 5.57 seconds to load)
330 examples, 0 failures

Combine all shared example expectations into one

Finished in 43.14 seconds (files took 5.05 seconds to load)
132 examples, 0 failures

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
spec/services/system_note_service_spec.rb
13 13 let(:expected_noteable) { noteable }
14 14 let(:commit_count) { nil }
15 15
16 it 'is valid' do
16 it 'has the correct attributes', :aggregate_failures do
  • Robert Speicher added 8 commits

    added 8 commits

    • ac11b5a5...51ceacb1 - 7 commits from branch master
    • 66b6c5f5 - Combine multiple expectations into one for shared system note example

    Compare with previous version

  • Robert Speicher added 2 commits

    added 2 commits

    • 24244d03 - 1 commit from branch master
    • 93f08ba0 - Combine multiple expectations into one for shared system note example

    Compare with previous version

  • Robert Speicher
  • Robert Speicher
    Robert Speicher @rspeicher ·
    Author Owner

    @DouweM Failure is https://gitlab.com/gitlab-org/gitlab-ce/issues/34323

  • Robert Speicher assigned to @DouweM

    assigned to @DouweM

  • Douwe Maan resolved all discussions

    resolved all discussions

  • Douwe Maan approved this merge request

    approved this merge request

  • Douwe Maan merged

    merged

  • Douwe Maan mentioned in commit ed1ca47c

    mentioned in commit ed1ca47c

    • Please register or sign in to reply