Update and fix resolvable note icons for easier recognition

What does this MR do?

Update and fix resolvable note icons for easier recognition

Before	After

Are there points in the code the reviewer needs to double check?

Regressed in https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/12931/diffs#79ea7020ff2bdc6a515cb8c8bf815c6e3e436386_544_547 where we added the following CSS and icon_status_success.svg wasn't built with external fill in mind.

svg {
  /* ... */
  path {
     fill: currentColor;
  }
}

Why was this MR needed?

Resolvable note icons regressed to filled in circles. UX was inspired by the bug and decided to move to a filled in circle version of the checkmark.

Does this MR meet the acceptance criteria?

• Changelog entry added, if necessary
• Review
  • Has been reviewed by UX
  • Has been reviewed by Frontend
• Conform by the merge request performance guides
• Conform by the style guides
• Squashed related commits together

What are the relevant issue numbers?

Closes #36582 (closed)

unmarked as a Work In Progress

changed title from WIP: Fix note resolved icon to Update and fix resolvable note icons for easier recognition

marked the checklist item Changelog entry added, if necessary as completed

assigned to @tauriedavis

@ClemMakesApps The frontend and Vue code here needs some review please

changed the description

@fatihacet can you review instead?

@jschatz1 wants me to help on ~"repo editor"

assigned to @fatihacet

cc @tauriedavis for UX review in case the unassignment removed from todos

added 9 commits

• ea15b574...24244d03 - 8 commits from branch master
• 847920e2 - Update and fix resolvable note icons for easier recognition

Compare with previous version

Thanks @MadLittleMods! Can we add a hover state to the filled version? Darkening the background to $green-700 should do the trick.

@tauriedavis pushed

added 1 commit

• e85362d5 - Update and fix resolvable note icons for easier recognition

Compare with previous version

LGTM! Thanks!

approved this merge request

rspec-pg 22 25 failure is on master, see https://gitlab.com/gitlab-org/gitlab-ce/issues/34323

marked the checklist item Has been reviewed by UX as completed

resolved all discussions

LGTM

Thanks @MadLittleMods @tauriedavis

enabled an automatic merge when the pipeline for e85362d5 succeeds

@MadLittleMods one of the builds is failed and I just retried it and enabled auto merge. Let's keep an eye on the build.

marked the checklist item Has been reviewed by Frontend as completed

@fatihacet The failure will probably not pass until a fix gets merged into master.

rspec-pg 22 25 failure is on master, see https://gitlab.com/gitlab-org/gitlab-ce/issues/34323

https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/13821#note_38541335

@MadLittleMods Ok since it's a Pick into Stable I am merging this one. Thanks for the heads up!

canceled the automatic merge

merged

mentioned in commit 6f0f65be

Picked into https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/14002, will merge into 9-5-stable ready for 9.5.3

removed Pick into Stable label

mentioned in commit 22940901

mentioned in issue #37406 (closed)

mentioned in merge request !14042 (merged)

mentioned in commit 066ce897

mentioned in merge request !14255 (merged)