Skip to content
Snippets Groups Projects

Link to project labels page

1 unresolved thread

What does this MR do?

Fixes the issue - https://gitlab.com/gitlab-org/gitlab-ce/issues/23472

Are there points in the code the reviewer needs to double check?

Please check the screenshot to ensure that this satisfies UX criteria

Why was this MR needed?

https://gitlab.com/gitlab-org/gitlab-ce/issues/23472

Screenshots (if relevant)

Screen_Shot_2017-08-28_at_12.11.39_AM

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

23472

Merge request reports

Pipeline #11502473 failed

Pipeline failed on brancho:Link_to_project_labels_page

Test coverage 50.06% (0.00%) from 1 job
The source branch Link_to_project_labels_page does not exist. Please restore it or use a different source branch.
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • @brycepj yes, you're right, i didn't notice it was there already. I just made the labels section look like the other sections when there are no labels. But the task was actually this > Link to /:namespace/:project/labels in the labels section of issue / MR sidebar if there are no labels. And I just guessed I should put that link on "Edit", which doesn't make much sense when i think about it now.

    So I should just remove @labels.any? and have that collapsible box with create/manage labels, search and stuff when "Edit" is clicked? Is that what was supposed to be done here?

    Edited by username-removed-911300
  • @brancho I see what you mean. I didn't look at the feature proposal as closely as I should have. I guess I'm not sure the proposal was the right fix, since if you click "Edit" when there are no labels, you can create a label from the dropdown. So it would be an extra layer of redirection adding a link to the labels page. But let's get a UX person to weigh in here.

    @sarrahvesselov could you or someone on your team give an opinion on this?

    tldr: it was proposed that it's confusing that the labels block in the sidebar doesn't show up if there aren't any labels. The original issue proposed displaying the block with a link to the labels page when there aren't any labels. @brancho implemented this, but now that I'm looking at it, it seems that we should display the labels block always, and use the existing flow -- when they click "Edit", they can create a new label from the dropdown. Original issue is here: https://gitlab.com/gitlab-org/gitlab-ce/issues/23472, if that helps.

  • added UX label

  • could you or someone on your team give an opinion on this?

    Thanks for pinging me on this one @brycepj. After reading the original issue and looking at this MR, I agree with your assessment here:

    we should display the labels block always, and use the existing flow -- when they click "Edit", they can create a new label from the dropdown

  • Hey @brycepj, I returned the labels block as you and Sarrah said :slight_smile:

  • @brancho looks like there's a failing spec (https://gitlab.com/brancho/gitlab-ce/-/jobs/31529841) -- it doesn't look related to your change though, so I'd Retry running it, and if that doesn't fix it, I'd try rebasing your branch against master.

    Edited by username-removed-408230
  • Please register or sign in to reply
    Loading