Skip to content
Snippets Groups Projects

Remove git refs used internally by GitLab from network graph

Merged Remove git refs used internally by GitLab from network graph
stanhu/gitlab-ce:fix-network-graph-refs into master
Merged Stan Hu requested to merge stanhu/gitlab-ce:fix-network-graph-refs into master

GitLab 8.0 removed satellites and started using git refs that began with refs/merge-requests/XXX and refs/tmp/XXX, which showed up in an ugly way in the network graph:

image

Closes #2702 (closed)

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Douwe Maan
    Douwe Maan @DouweM started a thread on the diff
    • app/helpers/graph_helper.rb
    1 1 module GraphHelper
    2 2 def get_refs(repo, commit)
    3 3 refs = ""
    4 refs << commit.ref_names(repo).join(' ')
    4 # Commit::ref_names already strips the refs/XXX from important refs (e.g. refs/heads/XXX)
  • Stan Hu Added 1 commit:

    Added 1 commit:

    • 4c62d54f - Use reject instead of select
  • Stan Hu Added 1 commit:

    Added 1 commit:

    • 150fb81e - Remove git refs used internally by GitLab from network graph
  • Stan Hu mentioned in issue #2724 (closed)

    mentioned in issue #2724 (closed)

  • Robert Speicher Reassigned to @DouweM

    Reassigned to @DouweM

  • Stan Hu mentioned in merge request gitlab_git!48 (closed)

    mentioned in merge request gitlab_git!48 (closed)

  • Douwe Maan Status changed to merged

    Status changed to merged

  • Douwe Maan mentioned in commit 4bf1e85c

    mentioned in commit 4bf1e85c

  • Stan Hu
    Stan Hu @stanhu ·
    Author Maintainer

    @DouweM, I submitted gitlab_git!48 (closed), so this change may be redundant if that one makes more sense.

  • Douwe Maan mentioned in merge request gitlab_git!48 (closed)

    mentioned in merge request gitlab_git!48 (closed)

  • Robert Speicher
    Robert Speicher @rspeicher ·
    Owner

    Picked into 8-0-stable.

    • Please register or sign in to reply