Use Gitlab::Git's Popen on that module's code
What does this MR do?
Gitaly Conversation: https://gitlab.com/gitlab-org/gitaly/issues/540
Use Gitlab::Git's Popen on that module's code
Are there points in the code the reviewer needs to double check?
No
Why was this MR needed?
This allows the current Gitaly migration to depend on less code outside of the Gitlab::Git module
Does this MR meet the acceptance criteria?
-
Changelog entry added, if necessary -
Documentation created/updated -
API support added -
Tests added for this feature/bug - Review
-
Has been reviewed by UX -
Has been reviewed by Frontend -
Has been reviewed by Backend -
Has been reviewed by Database
-
-
Conform by the merge request performance guides -
Conform by the style guides -
Squashed related commits together
What are the relevant issue numbers?
Adjustment necessary for https://gitlab.com/gitlab-org/gitaly/merge_requests/344#note_40062298
Merge request reports
Activity
added 1 commit
- 32a9601d - Use Gitlab::Git's Popen on that module's code
assigned to @jacobvosmaer-gitlab
assigned to @eReGeBe
added 59 commits
-
32a9601d...7bd66b76 - 58 commits from branch
master
- 7a488468 - Use Gitlab::Git's Popen on that module's code
-
32a9601d...7bd66b76 - 58 commits from branch
assigned to @rspeicher
added Gitaly label
mentioned in issue gitaly#540
mentioned in merge request gitaly!344 (merged)
assigned to @eReGeBe
assigned to @rspeicher
added 191 commits
-
b2ff24de...36dc65d5 - 190 commits from branch
master
- 34eeac61 - Use Gitlab::Git's Popen on that module's code
-
b2ff24de...36dc65d5 - 190 commits from branch
@eReGeBe I hope you don't mind but I rebased your branch off master to get things going while your OOO :).
assigned to @DouweM
@ahmadsherif thanks!
@DouweM mind reviewing this one?
mentioned in commit 70dc7e9a
mentioned in commit test-nick/gitlab-ce@550adc0f