Skip to content
Snippets Groups Projects

Resolve "Scope users by group inside dropdowns if I'm on group page (Issue, MRs)"

All threads resolved!

What does this MR do?

This retrieve the current group ID in the user dropdowns on the group's issuable list page so that only the group's members are returned in the filtering dropdowns (author and assignee).

Are there points in the code the reviewer needs to double check?

The data-group-id is already set on the search filter input (https://gitlab.com/gitlab-org/gitlab-ce/blob/46bdcd64056e8e5ed8d397b0ad5accaa7e5e9d06/app/helpers/search_helper.rb#L150-152), the only missing part was to retrieve it on the JS side.

Why was this MR needed?

To make the scoping of users consistent between the project's issuable list page and the group's issuable list page, as noted here: https://gitlab.com/gitlab-org/gitlab-ce/issues/20824#note_40119351.

Screenshots

For the following group members:

group-members

Before After
before0 after0
before1 after1

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

Closes #20824 (closed)

Edited by username-removed-128633

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • added 2 commits

    • cbdd13f6 - Scope users by group in issuable search bar
    • c66e3462 - Return only group's members in user dropdowns on issuables list pages

    Compare with previous version

  • added 1 commit

    • b06d5b96 - Return only group's members in user dropdowns on issuables list pages

    Compare with previous version

  • Phil Hughes resolved all discussions

    resolved all discussions

  • Phil Hughes approved this merge request

    approved this merge request

  • Phil Hughes mentioned in commit 2203e8fc

    mentioned in commit 2203e8fc

  • merged

  • @iamphill Thanks! ❤️

  • username-removed-128633 resolved all discussions

    resolved all discussions

  • Please register or sign in to reply
    Loading