Skip to content

WIP: Vueify image diff

username-removed-408677 requested to merge vueify-image-diff into master

What does this MR do?

Convert image diff to use Vue as a first step towards https://gitlab.com/gitlab-org/gitlab-ce/issues/35873 This also fixes several existing bugs with current image diffs

Are there points in the code the reviewer needs to double check?

Make sure everything is 💯

Why was this MR needed?

Related to Deliverable

Screenshots (if relevant)

Before (Inconsistent 2-up) After (Inconsistent 2-up)
2017-09-15_12.01.34 2017-09-15_11.57.22
Before (Swipe frame) After (Swipe frame)
Screen_Shot_2017-09-15_at_11.21.48_AM Screen_Shot_2017-09-15_at_11.21.09_AM

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

https://gitlab.com/gitlab-org/gitlab-ce/issues/35873, Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/32613, Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/37928

Edited by username-removed-408677

Merge request reports