Refactor BackupManager#remove_old

Open James EJ requested to merge jej/fix-backup-manager-remove-old into master


Refactored BackupManager timestamp/regex handling.

Verified that tests were working correctly in response to, and added names to describe the file names tested

Are there points in the code the reviewer needs to double check?

Yes, this will need to be rebased after the regex was updated in


  • Improve the test suite so we're confident that no files that aren't supposed to be deleted could be deleted by an improper match
  • Potentially move from a regex to something more procedural, with multiple guards


Edited by James EJ