merge_request: add work_in_progress to MR hooks

@stanhu 414cacd7 was all well and good, but I had missed that it wasn't also in hooks :) .

Added 1 commit:

• 12c0099f - merge_request: add work_in_progress to MR hooks

@ben.boeckel Could you rebase?

Added 36 commits:

• 12c0099f...b6564195 - 35 commits from branch gitlab-org:master
• 593bda37 - merge_request: add work_in_progress to MR hooks

Rebased.

CI failure is due to gems being inaccessible for spinach tests. Aren't they cached somewhere?

Added 37 commits:

• 593bda37...2c3355f9 - 36 commits from branch gitlab-org:master
• f9e2c0e3 - merge_request: add work_in_progress to MR hooks

Rebased again for conflicts.

!(current_expr).nil?

I think the model should change from:

  def work_in_progress?
    title =~ /\A\[?WIP\]?:? /i
  end

To something like:

  def work_in_progress?
    (title =~ /\A\[?WIP\]?:? /i) ? true : false
  end

or

  def work_in_progress?
    !!(title =~ /\A\[?WIP\]?:? /i)
  end

I think I've seen the !! pattern elsewhere. Not sure about the ?: one. Would that belong on a separate branch? If so, before or after this one lands?

Given all the other callers interpret the return value as true or false, I think it's fine to fold the change into this MR and have specs for this. You're welcome to open a new MR for that, though.

Added 28 commits:

• f9e2c0e3...54452412 - 26 commits from branch gitlab-org:master
• cf0315d7 - merge_request: coerce work_in_progress? into a boolean
• edba67d9 - merge_request: add work_in_progress to MR hooks

Updated.

Thanks. I'm confused why the diff is showing changes in the CHANGELOG that are already present in master:

Added 1 commit:

• c84a2ea8 - merge_request: add work_in_progress to MR hooks

That is…interesting. I would have expected git to conflict on something like that, not make a diff from thin air. Anyways, rebased again to remove the unnecessary diffs.

Thanks. Can you add a spec for #to_hook_attrs in merge_requests_spec.rb?

Added 1 commit:

• 8b4acad4 - merge_request: add work_in_progress to MR hooks