Skip to content
Snippets Groups Projects

Add CI build trace sections extractor

Merged Alessio Caiazza requested to merge 37970-ci-sections-tracking into master
All threads resolved!

What does this MR do?

This MR extracts timestamped section marker from build trace log.

As a first iteration, sections are just identified and recorded on DB.

Are there points in the code the reviewer needs to double check?

Why was this MR needed?

With https://gitlab.com/gitlab-org/gitlab-runner/merge_requests/689 gitlab-runner will start sending timestamped sections marker

Screenshots (if relevant)

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

See https://gitlab.com/gitlab-org/gitlab-runner/issues/2505 Closes #37970 (closed)

Edited by Kamil Trzcińśki

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Kamil Trzcińśki
  • Kamil Trzcińśki
  • @grzesiek Could you take a look at this and propose how we can implement the backend code?

  • Nice merge request @nolith! I left just a few notes! :evergreen_tree:

  • assigned to @nolith

  • Alessio Caiazza mentioned in merge request !14393 (merged)

    mentioned in merge request !14393 (merged)

  • Kamil Trzcińśki
  • Kamil Trzcińśki
  • Kamil Trzcińśki
  • Kamil Trzcińśki
  • Kamil Trzcińśki
  • Alessio Caiazza added 356 commits

    added 356 commits

    • 6fdc7dec...f1b8d79f - 350 commits from branch master
    • 65adc654 - Add CI build trace sections extractor
    • 198afe12 - DB related review
    • 5c560662 - Fix broken test
    • 3843208e - Code review corrections
    • 98bbd305 - Don't catch errors in Build#parse_trace_sections!
    • 5b4fbdf7 - DB migrations code review

    Compare with previous version

  • assigned to @ayufan

  • added 1 commit

    • 91f8e734 - Add CI build trace sections extractor

    Compare with previous version

  • @grzesiek Can you take a look?

  • assigned to @nolith

  • Grzegorz Bizon
  • added CI/CD label

  • added 1 commit

    Compare with previous version

  • added 1 commit

    • c0cfc9eb - Extract Ci::Build#parse_trace_sections! into a service

    Compare with previous version

  • Author Developer

    Migrations repacked and service extracted.

  • assigned to @ayufan

  • @yorickpeterse Can you review DB?

    @grzesiek Can you do one more Backend review?

    If everything will be fine I will do final review and Approve :)

  • Grzegorz Bizon
  • @ayufan Let's merge it! :tada: :rainbow:

  • yorickpeterse-staging marked the checklist item Has been reviewed by Database as completed

    marked the checklist item Has been reviewed by Database as completed

  • Kamil Trzcińśki resolved all discussions

    resolved all discussions

  • Kamil Trzcińśki approved this merge request

    approved this merge request

  • Kamil Trzcińśki added 407 commits

    added 407 commits

    Compare with previous version

  • Kamil Trzcińśki approved this merge request

    approved this merge request

  • Kamil Trzcińśki enabled an automatic merge when the pipeline for 5ee20b63 succeeds

    enabled an automatic merge when the pipeline for 5ee20b63 succeeds

  • Kamil Trzcińśki marked the checklist item Changelog entry added, if necessary as completed

    marked the checklist item Changelog entry added, if necessary as completed

  • Kamil Trzcińśki marked the checklist item Documentation created/updated as completed

    marked the checklist item Documentation created/updated as completed

  • Kamil Trzcińśki marked the checklist item API support added as completed

    marked the checklist item API support added as completed

  • Kamil Trzcińśki marked the checklist item Tests added for this feature/bug as completed

    marked the checklist item Tests added for this feature/bug as completed

  • Kamil Trzcińśki marked the checklist item Has been reviewed by UX as completed

    marked the checklist item Has been reviewed by UX as completed

  • Kamil Trzcińśki marked the checklist item Has been reviewed by Frontend as completed

    marked the checklist item Has been reviewed by Frontend as completed

  • Kamil Trzcińśki marked the checklist item Has been reviewed by Backend as completed

    marked the checklist item Has been reviewed by Backend as completed

  • Kamil Trzcińśki marked the checklist item Conform by the merge request performance guides as completed

    marked the checklist item Conform by the merge request performance guides as completed

  • Kamil Trzcińśki marked the checklist item Conform by the style guides as completed

    marked the checklist item Conform by the style guides as completed

  • Kamil Trzcińśki marked the checklist item Squashed related commits together as completed

    marked the checklist item Squashed related commits together as completed

  • mentioned in commit 8eec69ef

  • Please register or sign in to reply
    Loading