Skip to content
Snippets Groups Projects

Added skeleton loading paradigm to UX guide

Merged Dimitrie Hoekstra requested to merge skeleton-loading-paradigm into master

What does this MR do?

Adds skeleton loading paradigm to ux guide

Are there points in the code the reviewer needs to double check?

Why was this MR needed?

Paradigms need to be documented

Screenshots (if relevant)

See http://localhost:3000/help/development/ux_guide/components.md

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

Closes https://gitlab.com/gitlab-org/gitlab-design/issues/35

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Robert has a good point about the video example. It doesn't fit the guidelines written

  • Dimitrie Hoekstra resolved all discussions

    resolved all discussions

  • added 2 commits

    • d894a10f - minor typo and wording fixes to first paragraph of skeleton loading in ux guide
    • aff63357 - Replaced the skeleton loading video with a gif which displays more appropriate content

    Compare with previous version

  • @rspeicher you are totally right! fixed!

    Can we get this merged?

  • need to fix one last doc lint error

  • added 1 commit

    • af330b1f - changed link in animation section for skeleton loading

    Compare with previous version

  • fixed

  • Robert Speicher
  • @dimitrieh Two minor things.

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading