Disable the "Report abuse" button if a user has already been reported

Hello,

I've implemented the feature request #2330 (closed). Here is what it looks like:

I hope that's an acceptable solution.

cc @DouweM

Added 1 commit:

• a5297969 - Streamline the "Report button"

@DouweM Thanks very much for the review, I've pushed a commit that should address all your points. Also, I've decided to simplify the tooltip labels since I think that repeating the user name in the tooltips doesn't add much value in the context of a user page.

User not already reported:

User already reported (button disabled):

I think this is a more acceptable and simpler solution like that!

Added 2 commits:

• 5f95a5e0 - Disable the "Report abuse" button if a user has already been reported
• 2e3de94e - Streamline the "Report button"

Added 1 commit:

• ea72d53e - Streamline the "Report button"

Thanks a lot @rymai, looks good to me! I've retried the builds and will merge once they're green.

For some reason, the builds wouldn't get out of the pending status. I ran them here instead. The one failure is unrelated, so I'm merging.

Status changed to merged

mentioned in commit 96c2e225

mentioned in issue #2330 (closed)

we use dash-style for css class names in GitLab. cc @DouweM

It better to use link_to unless you explicitly need %a. cc @DouweM

Do not assign #report_abuse_btn ID if its not used. cc @DouweM

@dzaporozhets Will fix.

Try to avoid using html tags and style css classes in tests. Its easy to break such test. For example:

• I change btn-close to btn-danger
• I change span to button

cc @DouweM