Skip to content
Snippets Groups Projects

Update kubernetes.rb to use strict_encode64 for the certificate. This creates the correct format.

Closed username-removed-197097 requested to merge venatir/gitlab-ce:patch-26 into master

What does this MR do?

Changes the kubernetes certificate-authority-data in the config file in the runner to be rfc4648 compliant.

Are there points in the code the reviewer needs to double check?

Why was this MR needed?

The runner is not working properly failing when it needs to run kubernetes commands. This is due to the KUBECONFIG file using the wrong base64 encoding for the certificate. Please consider adding a test for this. Clearly this feature was shipped without testing.

Screenshots (if relevant)

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

https://gitlab.com/gitlab-org/gitlab-ce/issues/38651

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
Please register or sign in to reply
Loading