Skip to content

[rails 5] Fix spec/routing/project_routing_spec.rb

username-removed-86853 requested to merge rails5_fix_project_routing_spec into rails5

What does this MR do?

It fixes spec/routing/project_routing_spec.rb failures like

  1) project routing Projects::WikisController routing to #history
     Failure/Error: expect(get('/gitlab/gitlabhq/wikis/1/history')).to route_to('projects/wikis#history', namespace_id: 'gitlab', project_id: 'gitlabhq', id: '1')

       The recognized options <{"format"=>:html, "controller"=>"projects/wikis", "action"=>"history", "namespace_id"=>"gitlab", "project_id"=>"gitlabhq", "id"=>"1"}> did not match <{"namespace_id"=>"gitlab", "project_id"=>"gitlabhq", "id"=>"1", "controller"=>"projects/wikis", "action"=>"history"}>, difference:.
       --- expected
       +++ actual
       @@ -1 +1 @@
       -{"namespace_id"=>"gitlab", "project_id"=>"gitlabhq", "id"=>"1", "controller"=>"projects/wikis", "action"=>"history"}
       +{"format"=>:html, "controller"=>"projects/wikis", "action"=>"history", "namespace_id"=>"gitlab", "project_id"=>"gitlabhq", "id"=>"1"}
     # ./spec/routing/project_routing_spec.rb:153:in `block (3 levels) in <top (required)>'

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/12841

Merge request reports