Improve project page height (!1487) · Merge requests · GitLab.org / GitLab FOSS · GitLab

Snippets Groups Projects

Do not update/delete: Banner broadcast message test data

Do not update/delete: Notification broadcast message test data

Merged username-removed-127938 requested to merge projects into master 9 years ago

old thing. Grey block not aligned to the bottom. It was a scroll even with short project description.

New awesome stuff, no scroll, grey block aligned to the bottom.

Activity

username-removed-444 @dzaporozhets started a thread on an old version of the diff 9 years ago
Last reply by username-removed-444 9 years ago

username-removed-444 @dzaporozhets started a thread on an old version of the diff 9 years ago

username-removed-444 @dzaporozhets started a thread on an old version of the diff 9 years ago

username-removed-444 @dzaporozhets started a thread on an old version of the diff 9 years ago

username-removed-444 @dzaporozhets started a thread on an old version of the diff 9 years ago

username-removed-444 @dzaporozhets started a thread on an old version of the diff 9 years ago

username-removed-444 @dzaporozhets started a thread on an old version of the diff 9 years ago

username-removed-444 @dzaporozhets started a thread on an old version of the diff 9 years ago

username-removed-127938 @skyruler 9 years ago

Author Contributor

Okay

username-removed-127938 Title changed from Projects to Improve project page height 9 years ago

Title changed from Projects to Improve project page height

username-removed-127938 Added 1 commit: 9 years ago

Added 1 commit:

fd86b669 - CSS markup fixed

username-removed-444 @dzaporozhets started a thread on the diff 9 years ago

app/assets/stylesheets/pages/projects.scss

 .content {
  height: 100%;
  width: 100%;
+}
 .max-height {
  height: 100%;
  display: table;
  width: 100%;
+}
 section {
  height: 100%;
  display: table-row;
+}

username-removed-127938 Added 1 commit: 9 years ago

Added 1 commit:

5ebcf21b - section and .content now in layout.cssc

username-removed-127938 Added 1 commit: 9 years ago

Added 1 commit:

acdb5f34 - max height to layout.scss

username-removed-127938 Added 1 commit: 9 years ago

Added 1 commit:

75c03530 - removed max-heght from project.scss

username-removed-444 @dzaporozhets 9 years ago

Owner

username-removed-444 Status changed to merged 9 years ago

Status changed to merged

username-removed-444 mentioned in commit 9 years ago

mentioned in commit 2b493695

username-removed-444 @dzaporozhets 9 years ago

Owner

@skyruler changes in this MR cause strange behaviour for mobile devices. it cause different pages rendered with different scale. Probably its because all this display: table hacks. I am going to revert this MR since it breaks more that it fixes. If you will have better fix - please submit new MR

username-removed-127938 @skyruler 9 years ago

Author Contributor

ok i'll check on mobile, do you have a screenshot of something?

Please register or sign in to reply