Skip to content
Snippets Groups Projects

Basic RSpec/benchmark-ips powered benchmark suite

Merged yorickpeterse-staging requested to merge benchmark-suite into master

Corresponding issue: #2909 (closed), see the commit messages for more details.

A few things to note:

  1. The current use of subject isn't exactly easy on the eyes due to them having to return a Proc, I'm not sure yet how (and if) we can work around this.
  2. The maximum amount of iterations in the current User.by_login benchmark is arbitrary, we might have to adjust it once said method's performance has been improved.
  3. Benchmarks currently take 2 seconds to warm up and 5 seconds to run (benchmark-ips defaults).
  4. The custom RSpec matcher file (benchmark_matchers.rb) is a bit messy, any feedback on this would be appreciated

Any comments/feedback on this would be greatly appreciated.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
Please register or sign in to reply
Loading