Support filtering by "Any" milestone or issue and fix "No Milestone" and "No Label" filters (!1523) · Merge requests · GitLab.org / GitLab FOSS · GitLab

Snippets Groups Projects

Do not update/delete: Banner broadcast message test data

Do not update/delete: Notification broadcast message test data

An error occurred while fetching the assigned milestone of the selected merge_request.

Merged Stan Hu requested to merge stanhu/gitlab-ce:improve-label-milestones-filter into master 9 years ago

This MR adds support for filtering by "Any" milestone or label. It also changes the "No Milestone" filter to only show issues/merge requests that have NO milestones and adds a similar "No Label" filter.

Screenshots:

Closes #2619 (closed)

Closes https://github.com/gitlabhq/gitlabhq/issues/9631

Activity

Stan Hu Reassigned to @dzaporozhets 9 years ago

Reassigned to @dzaporozhets
Stan Hu Added 1 commit: 9 years ago
Added 1 commit:

c86c02e9 - Simplify query (no need for join)
Stan Hu Added 1 commit: 9 years ago
Added 1 commit:

0930a7bd - Support filtering by "Any" milestone or issue and fix "No Milestone" and "No Label" filters
Achilleas Pipinellis @axil · 9 years ago

Maintainer

👍
Stan Hu Added 14 commits: 9 years ago
Added 14 commits:

0930a7bd...cc8c91a1 - 13 commits from branch gitlab-org:master

dfbbc806 - Support filtering by "Any" milestone or issue and fix "No Milestone" and "No Label" filters
username-removed-444 @dzaporozhets · 9 years ago

Owner

👍
username-removed-444 Status changed to merged 9 years ago

Status changed to merged
Douwe Maan @DouweM started a thread on the diff 9 years ago

app/finders/issuable_finder.rb

  def by_label(items)
    if params[:label_name].present?
      label_names = params[:label_name].split(",")
      if params[:label_name] == Label::None.title
        item_ids = LabelLink.where(target_type: klass.name).pluck(:target_id)

Douwe Maan mentioned in issue #3078 (closed) 9 years ago

mentioned in issue #3078 (closed)

Please register or sign in to reply