LDAP email address downcasing (!1550) · Merge requests · GitLab.org / GitLab FOSS · GitLab

Snippets Groups Projects

Do not update/delete: Banner broadcast message test data

Do not update/delete: Notification broadcast message test data

An error occurred while fetching the assigned milestone of the selected merge_request.

Merged Drew Blessing requested to merge dblessing/gitlab-ce:fix_email_downcasing into master 9 years ago

Fixes #2960 (closed)

In the event we cannot match an LDAP user by DN we attempt to find an identity by email address and then update the DN. In this case the identity is matched by email address.

If the user's email address in LDAP has an upper case character we cannot find a match in the GitLab database. GitLab downcases emails before the user object is saved.

This merge request downcases the email from LDAP before we lookup by email. I also added a test to prevent a regression.

Activity

Drew Blessing mentioned in issue #2960 (closed) 9 years ago

mentioned in issue #2960 (closed)
Douwe Maan @DouweM · 9 years ago

Maintainer

Looks good to me!
Drew Blessing mentioned in issue #2572 (closed) 9 years ago

mentioned in issue #2572 (closed)
Robert Speicher Status changed to merged 9 years ago

Status changed to merged
Robert Speicher mentioned in commit 42603af3 9 years ago

mentioned in commit 42603af3
Robert Speicher @rspeicher · 9 years ago

Owner

Picked into 8-0-stable.
Robert Speicher Reassigned to @rspeicher 9 years ago

Reassigned to @rspeicher
Robert Speicher Milestone changed to 8.0 9 years ago

Milestone changed to 8.0

Please register or sign in to reply