Allow dashboard and group issues/MRs to be filtered by label
Merge request reports
Activity
Added 65 commits:
-
3a69dd20...82da19ce - 64 commits from branch
master - d51c5562 - Merge branch 'master' into filter-label
-
3a69dd20...82da19ce - 64 commits from branch
Added 1 commit:
- d10e3c44 - Merge branch 'master' into filter-label
Reassigned to @rspeicher
@DouweM I'd appreciate some context about why this was needed, what it does, etc.
- app/models/group_label.rb 0 → 100644
1 class GroupLabel Would this be better as a
Struct?For both this and
GroupMilestoneI'm not sure they need to be "model" classes -- they're only used in their respective service classes. Maybe we can move their definitions there.Edited by Robert Speicher
92 92 end 93 93 end 94 94 95 def project_labels_options(project) 96 labels = project.labels.to_a 97 labels.unshift(Label::None) 98 labels.unshift(Label::Any) 99 options_from_collection_for_select(labels, 'name', 'title', params[:label_name]) 95 def projects_labels_options 96 labels = 97 if @project 98 @project.labels 99 else 100 Label.where(project_id: @projects) 101 end Not specifically, but it's covered by feature specs for the pages this in used in that would fail if this crashed.
There is no case where neither is set, because it's only used in issuable indexes, more specifically the dashboard, group and project issue and MR indexes, all of which have either.
Reassigned to @DouweM
@rspeicher It allows us to go to the gitlab-org group and find
promisedissues across gitlab-ce and gitlab-ee. The use case is basically the same as filtering milestones across projects.Reassigned to @rspeicher
mentioned in commit f4d3639a
mentioned in commit c856a7a5
